Paths

Table of Contentst

Differential D363

New map - India
ClosedPublic
Actions

Authored by Hannibal_Barca on Apr 19 2017, 8:00 PM.

Details

Reviewers

elexis

Commits

rP19447: Random map script India.

Summary

New map created by me from Lake. No forests, just straggler trees, some wildlife. Overall looks OK.

Possible description:
"Central India just before the monsoon season - a parched land awaits the life-bringing rain which is already two months late. Due to the extended dryness and scorching heat, only the largest lake remains. The hardy trees which have survived the climate are spread out, yet not too scarce."

Test Plan

Test map for resource collisions and the usual stuff.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Hannibal_Barca created this revision.Apr 19 2017, 8:00 PM

elexis added a subscriber: elexis.Apr 19 2017, 8:07 PM

elexis added inline comments.

binaries/data/mods/public/maps/random/india.js
34 ↗	(On Diff #1367)	that function exists already, so you can nuke this function and PI12
54 ↗	(On Diff #1367)	unused, nuke
56 ↗	(On Diff #1367)	unneeded comment
66 ↗	(On Diff #1367)	unneeded comment
259 ↗	(On Diff #1367)	After removing the comments and replacing the variables that occur only once with it's value, we end up with: createAreas( new ChainPlacer(2, floor(scaleByMapSize(4, 6)), 3, 1), [ new LayeredPainter([tCliff, tDirt1], [2]), new SmoothElevationPainter(ELEVATION_SET, 3, 4), unPaintClass(clWater) ], borderClasses(clWater, 4, 7), scaleByMapSize(12, 130) * 2, 150 );
276 ↗	(On Diff #1367)	missing semicolon
288 ↗	(On Diff #1367)	randIntExclusive(0, mapSize), since randInt will be removed (see bb's megacleanuppatch)
298 ↗	(On Diff #1367)	That replacing group by it's value can be done here and below as well
319 ↗	(On Diff #1367)	unneeded comment
371 ↗	(On Diff #1367)	unneeded comments
397 ↗	(On Diff #1367)	more unneeded comments

do u have a screeni?

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/830/ for more details.

Harbormaster completed remote builds in B1201: Diff 1367.Apr 19 2017, 9:49 PM

Hannibal_Barca updated this revision to Diff 1385.Apr 20 2017, 10:24 PM

Hannibal_Barca edited the summary of this revision. (Show Details)

Made a template for Asian Elephant infants as till now there was only an african one and it showed in the name (name is basically all that's changed).

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/836/ for more details.

Harbormaster completed remote builds in B1212: Diff 1385.Apr 20 2017, 11:10 PM

There should be some city radius patch, otherwise it look too mono-textured
Just one or two tiny oasis to break the map into distinguishable parts?
Uhm, hills/mountains maybe?

binaries/data/mods/public/maps/random/india.js
211 ↗	(On Diff #1385)	where is it?
220 ↗	(On Diff #1385)	Remove the comments and make that a single line, same below, well, unused variables? jshint.com can show those
334 ↗	(On Diff #1385)	See createFood calls in other recent maps to see proper whitespace formatting
binaries/data/mods/public/simulation/templates/gaia/fauna_elephant_asian_infant.xml
1 ↗	(On Diff #1385)	Copy pasta not allowed See D257 and rP19295 Should make a separate patch for that

Somehow the lake disappeared along the finalization of the map. Re-added.

Hannibal_Barca edited the summary of this revision. (Show Details)Apr 22 2017, 5:40 PM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/858/ for more details.

Harbormaster completed remote builds in B1240: Diff 1425.Apr 22 2017, 6:24 PM

elexis edited the summary of this revision. (Show Details)Apr 23 2017, 3:47 AM

Code Style: Same diseases as in every other RMS, most of them cleaned by you already, did some more inlining of groups, let, ++i

Terrain:
Nice, especially that the textures aare height-dependent. The dirt comes out much better with some of the lake still being watery.

Flora:

Agree that the other tree types don't fit.
Nice bushes

Fauna:

Boar appears in india
Wildebeest still only appearing in south africa, so not having it is fine

Geology:

The texture of the stone mine formation doesn't fit to the dirty terrain texture, but that is embedded in the model
For the life of me I can't find a city radius patch that fit's to said dirty texture, so we can keep it as is

Resource balancing:

Some people will not like the small number of trees and it's distribution, but it's their task as a player to cope with that
Amount of huntable elephants is good, especially it isn't too much like on other maps where players can get a rocket start with tens of thousnads of food without doing any fields in the first 10min
Slightly too few metal mines. This is partially due to our favorite placement bug #4294. Making this scaleByMapSize(2, 12) (from 2,8)

Map Preview: made one

This revision is now accepted and ready to land.Apr 23 2017, 3:59 AM

Closed by commit rP19447: Random map script India. (authored by elexis). · Explain WhyApr 23 2017, 4:03 AM

This revision was automatically updated to reflect the committed changes.

elexis mentioned this in D376: Asian Elephant Infant on India.Apr 23 2017, 4:36 AM