Page MenuHomeWildfire Games

Asian Elephant Infant on India
ClosedPublic

Authored by elexis on Apr 23 2017, 4:36 AM.

Details

Summary

The India map from D363 was supposed to have an elephant infant, but it should be an asian, not african infant.
In order to avoid duplication, make the existing template a parent template and only change the string in the new one.

Test Plan

Apply the patch, start the India map and see that child elephant.
Start the Serengeti scenario map and see the old african elephant still exists.
Notice that the two templates are minimal and contain no copypasta.
Notice that the name of the parent template is in line with rP19295.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

elexis created this revision.Apr 23 2017, 4:36 AM
Vulcan added a subscriber: Vulcan.Apr 23 2017, 10:16 AM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/872/ for more details.

Thank you very much for this patch, really awesome to have infants on the map, I didn't want to have them at first because they are african ones but this solves that problem.
Patch assumes you already have template_unit_fauna_hunt_skittish_elephant_infant.xml so I created it and then could apply patch. Followed test plan and found nothing amiss.

Hannibal_Barca accepted this revision.Apr 23 2017, 4:00 PM
This revision is now accepted and ready to land.Apr 23 2017, 4:00 PM
This revision was automatically updated to reflect the committed changes.

Thanks for the testing