Differential D384
Corsica vs Sardinia tiny mapsizes Authored by elexis on Apr 25 2017, 3:30 PM.
Details As reported by bb in #4531, the map Corsica vs Sardinia completely fails to generate on many map seeds, probably since the map was introduced. So adding a simple check for map boundaries fixes the issue. If someone comes up with a better formula, feel free to post it. Generate lots of tiny corsica vs sardinia maps. Notice that if we do the boundary checks earlier for example before the createArea call or even the startX boundary check before the endX assignment, we get way worse results and inaccessible beaches.
Diff Detail
Event TimelineComment Actions Build is green Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! http://jw:8080/job/phabricator/890/ for more details. Comment Actions Noticing some style ugliness in the surrounding code, but out of scope. |