Differential D4186
Corrected hasDealtWithTech in TriggerHelper Authored by Grapjas on Jun 30 2021, 5:26 PM.
Details
HasDealtWithTech returned true if the tech was queued up or started, which is offputting if you expect it to only return true if it has been researched like the function name suggest. Added a Test version of the function, which still does count queued and started researching techs as finished. Check that hasDealtWithTech only returns true when the tech has finished.
Diff Detail
Event TimelineComment Actions I dont see where name of the function suggest that technology is researched. Comment Actions It's not obvious to me, in any case it's easily misunderstood. Imo for something to be 'dealt with' means that it's been completed, otherwise it still hasn't been dealt with. Though, I could rename the added function to HasResearchedTech, and revert the original function's name back. Comment Actions A function just returning cmpTechnologyManager.IsTechnologyResearched(techName), if we need it, should be named something like IsTechnologyResearched. If you have a better name for a function returning cmpTechnologyManager.IsTechnologyQueued(techName) || cmpTechnologyManager.IsTechnologyStarted(techName) || cmpTechnologyManager.IsTechnologyResearched(techName) feel free to propose it. |