Page MenuHomeWildfire Games
Differential D437

Don't use relative templates in some templates until they are supported.
AbandonedPublic
Actions

Authored by fatherbushido on May 7 2017, 8:40 AM.

Details

Reviewers
elexis
Summary

As described in the title

Test Plan

Run the related script in source/tools/entity (after generating the rng for the public mod).
perl -I ~/0adfolder/source/tools/entity entvalidate.pl

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
/ps/trunk
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 1500
Build 2368: Vulcan BuildJenkins
Build 2367: arc lint + arc unit

Event Timeline

fatherbushido created this revision.May 7 2017, 8:40 AM
Vulcan added a subscriber: Vulcan.May 7 2017, 9:33 AM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/1043/ for more details.

Harbormaster completed remote builds in B1500: Diff 1699.May 7 2017, 9:33 AM
elexis retitled this revision from Don't use relative templates in some templates until they are not supported. to Don't use relative templates in some templates until they are supported..May 7 2017, 2:34 PM
fatherbushido added a reviewer: elexis.May 7 2017, 2:46 PM

ah yes, I messed the title :p

fatherbushido added a comment.May 7 2017, 3:12 PM

or wait for D268 (in both case we should edit those templates)

fatherbushido abandoned this revision.May 29 2017, 8:39 PM

As they validate (by chance) and that only the perl script entvalidate doesn' t validate, perhaps it's not the good thing to revert that and redo that when it will be fully handle (there is also Cost). So I prefer abandon that.

Revision Contents
Changeset List

PathSize
binaries/
data/
mods/
public/
simulation/
templates/
2 lines
units/
2 lines
4 lines

Diff 1699

View Options

binaries/data/mods/public/simulation/templates/template_structure_defense_sentry_tower.xml

Loading...
View Options

binaries/data/mods/public/simulation/templates/units/pers_mechanical_siege_ram.xml

Loading...
View Options

binaries/data/mods/public/simulation/templates/units/spart_champion_infantry_sword.xml

Loading...
Wildfire Games · Phabricator