Differential D4978

[WIP] [MACOS] Fix Attempt for the fullscreen bug
Needs ReviewPublic
Actions

Authored by Stan on Apr 4 2023, 7:49 PM.

Details

Reviewers: None

Summary

Sometimes when clicking on the maximising green button it does not work and the cursor gets offseted

Test Plan

TODO

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Lint Skipped

Unit

Unit Tests Skipped

Build Status

Buildable 21795
Build 53012: Vulcan Build	Jenkins
Build 53011: Vulcan Build (macOS)	Jenkins
Build 53010: Vulcan Build (Windows)	Jenkins

Event Timeline

Stan created this revision.Apr 4 2023, 7:49 PM

Build failure - The Moirai have given mortals hearts that can endure.

builderr-debug-macos.txt
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/liblobby_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libsimulation2_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libengine_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libgraphics_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libatlas_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libgui_dbg.a(precompiled.o) has no symbols
../../../source/lib/sysdep/os/osx/osx_sdl.mm:30:10: fatal error: 'SDL_syswm.h"' file not found
#include <SDL_syswm.h">
         ^~~~~~~~~~~~~~
1 error generated.
make[1]: *** [obj/lowlevel_Debug/osx_sdl.o] Error 1
make: *** [lowlevel] Error 2

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/6921/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/8009/display/redirect

Harbormaster completed remote builds in B21795: Diff 21717.Apr 4 2023, 8:11 PM

Stan requested review of this revision.Apr 4 2023, 8:11 PM

can't reproduce the issue on intel mac.

@real_tabasco_sauce: It usually happens when coming back from the mod selection.
It also seems to happen sometimes when plugging a screen