Page MenuHomeWildfire Games

Fixes SPIRV compile script for newer versions of spirv-reflect
ClosedPublic

Authored by vladislavbelov on Sep 7 2023, 7:51 PM.

Details

Reviewers
None
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP27845: Fixes SPIRV compile script for newer versions of spirv-reflect.
Summary

After https://github.com/KhronosGroup/SPIRV-Reflect/commit/56d6806ad1b6a210c4f745804a072189ad25c537 spirv-reflect no longer outputs DrawUniform as a push constant block name but as a push constant block type name.

Test Plan
  1. Download rules from https://releases.wildfiregames.com/spir-v/rules.latest.json
  2. Run source/tools/spirv/compile.py "binaries\data\mods\mod" rules.json "output-mod" -d "binaries\data\mods\mod" -p canvas2d

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vladislavbelov created this revision.Sep 7 2023, 7:51 PM
vladislavbelov edited the test plan for this revision. (Show Details)
Vulcan added a comment.Sep 7 2023, 7:52 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/7258/display/redirect

Vulcan added a comment.Sep 7 2023, 7:56 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/8347/display/redirect

vladislavbelov requested review of this revision.Sep 7 2023, 8:38 PM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 20 2023, 7:26 PM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.