Page MenuHomeWildfire Games
Differential D5155

Don't use std::shared_ptr in CStrIntern
Needs ReviewPublic
Actions

Authored by phosit on Oct 11 2023, 4:07 PM.

Details

Reviewers
vladislavbelov
Summary

Now there is less allocation and reference counting.

Test Plan

Start the game nothing should have changed.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Lint Skipped
SeverityLocationCodeMessage
Errorsource/ps/CStrIntern.cpp:1LICENCE YEAR1Inaccurate Copyright Year
Unit
Unit Tests Skipped
Build Status
Buildable 22457
Build 54967: Vulcan BuildJenkins
Build 54966: Vulcan Build (macOS)Jenkins
Build 54965: Vulcan Build (Windows)Jenkins

Event Timeline

phosit created this revision.Oct 11 2023, 4:07 PM
Vulcan added a comment.Oct 11 2023, 4:07 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/7379/display/redirect

Vulcan added a comment.Oct 11 2023, 4:14 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/8468/display/redirect

Harbormaster completed remote builds in B22457: Diff 22394.Oct 11 2023, 4:28 PM
phosit requested review of this revision.Oct 11 2023, 4:28 PM

Revision Contents
Changeset List

PathSize
source/
ps/
10 lines

Diff 22394

View Options

source/ps/CStrIntern.cpp

Loading...
Wildfire Games · Phabricator