Page MenuHomeWildfire Games

Remove unused structs related to StringsKeyProxy
Changes PlannedPublic

Authored by phosit on Oct 11 2023, 4:16 PM.

Details

Reviewers
vladislavbelov
Summary

Untill C++20 std::unordered_map isn't able to use such proxyes. If we want to use it in C++20 we should implement them in terms of std::string& or std::string_view.

Test Plan

Compile it.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Lint Skipped
SeverityLocationCodeMessage
Errorsource/ps/CStrIntern.cpp:1LICENCE YEAR1Inaccurate Copyright Year
Unit
Unit Tests Skipped
Build Status
Buildable 22458
Build 54970: Vulcan BuildJenkins
Build 54969: Vulcan Build (macOS)Jenkins
Build 54968: Vulcan Build (Windows)Jenkins

Event Timeline

phosit created this revision.Oct 11 2023, 4:16 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/7380/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/8469/display/redirect

phosit requested review of this revision.Oct 11 2023, 4:50 PM
phosit planned changes to this revision.Oct 13 2023, 10:53 PM

It should be repaired instead of removed.