Differential D5248

Fix wrong default in "scaleByMapArea"
ClosedPublic
Actions

Authored by marder on Feb 25 2024, 4:51 PM.

Details

Reviewers

Feldfeld

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rP28042: Fix wrong default in "scaleByMapArea"

Summary

Patch / noticed by @Feldfeld

https://code.wildfiregames.com/rP25894#61879

Doesn't have any consequences as the function is only called via the "scaleByMapAreaAbsolute"

Test Plan

double check that nothing breaks. but otherwise lgtm

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marder created this revision.Feb 25 2024, 4:51 PM

marder mentioned this in rP25894: Add quadratic scaling function in rmgen library and use it for decorations..

Looks like the autobuilds are not finishing so I can't give the accept action.
I noticed the issue by calling directly the function in my latest feldmap, so I am of course very confident this patch is correct.

Now you can ;)

Thanks

This revision is now accepted and ready to land.Feb 27 2024, 8:41 PM

This revision was landed with ongoing or failed builds.Feb 28 2024, 7:48 AM

Closed by commit rP28042: Fix wrong default in "scaleByMapArea" (authored by marder). · Explain Why

This revision was automatically updated to reflect the committed changes.

marder added a commit: rP28042: Fix wrong default in "scaleByMapArea".

Revision Contents
Changeset List

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

maps/

random/

rmgen/

library.js

6 lines

Diff 22808

View Options

ps/trunk/binaries/data/mods/public/maps/random/rmgen/library.js

Fix wrong default in "scaleByMapArea"ClosedPublicActions