Page MenuHomeWildfire Games

Storehouse cleanup

Authored by temple on Jul 9 2017, 2:44 AM.



Storehouses miraculously all have the same dimensions, and while some obstructions could be a tiny bit smaller I didn't think anything (besides Carthage) was worth changing.

Test Plan

See that the Carthage storehouse looks okay.

Diff Detail

rP 0 A.D. Public Repository
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

temple created this revision.Jul 9 2017, 2:44 AM
bb added a subscriber: bb.Sep 7 2017, 2:50 PM

ptol storehouse has useless 8 height. Not sure if ptol should have 4*4 rubble, maybe just 3*3 is correct

5 ↗(On Diff #2873)

normal things have 8 not sure if conflicting

bb added a comment.EditedSep 7 2017, 2:54 PM

also celting storehouses seem to overlap a bit Hellenic also slightly but less
Maybe maur needs a check too

temple updated this revision to Diff 3676.Sep 16 2017, 1:22 AM

Changed a few.

temple updated this revision to Diff 3725.Sep 19 2017, 4:58 PM

Added largest footprint sizes to skirmish structures.

bb added inline comments.Sep 22 2017, 6:14 PM
5 ↗(On Diff #3725)

random value since the height is fairly the same as the other buildings

7 ↗(On Diff #3725)

depth="17.0" looks better to me (smaller not possible, notice there are 2 actors with sorta different size)

10 ↗(On Diff #3725)

shouldn't that become a 4x4 rubble and foundation?

temple updated this revision to Diff 3754.Sep 22 2017, 10:25 PM
temple marked 2 inline comments as done.Sep 22 2017, 10:27 PM
temple added inline comments.
7 ↗(On Diff #3725)

(I knew houses had different actors but didn't realize this one did too.)

bb accepted this revision.Sep 24 2017, 12:58 PM
This revision is now accepted and ready to land.Sep 24 2017, 12:58 PM
This revision was automatically updated to reflect the committed changes.