Page MenuHomeWildfire Games

Show number of buddies in a game in lobbys gamelist
Needs ReviewPublic

Authored by ffffffff on Aug 18 2017, 5:18 PM.
This revision needs review, but all reviewers have resigned.



Showing how many buddies are in a game behind the name in yellow with dot


Test Plan


Diff Detail

Lint Skipped
Unit Tests Skipped

Event Timeline

ffffffff created this revision.Aug 18 2017, 5:18 PM
ffffffff retitled this revision from Show buddy number in a game in lobby to Show number of buddies in a game in lobbys gamelist.Aug 18 2017, 7:29 PM
elexis requested changes to this revision.Aug 19 2017, 10:56 AM

Idea ok, but not a fan of mixing different information in the same column.

For D125 we had added rudimentary support for optional columns. We should make this an optional column too IMO. Then we can add even more verbose information for the people who want that.
But we should really get D457 finished, so that we don't have to hardcode the column widths in JS.

Another idea might be to change the existing buddy column to show a number (or nothing for 0) instead of a circle.

This revision now requires changes to proceed.Aug 19 2017, 10:56 AM

approach: (also teams column) (and observerable together with observer number column)

i think i help then D457 to come to an end.

elexis resigned from this revision.Dec 12 2017, 8:36 PM