We need to restart the game to change the quality. So the patch improve this.
It calls CreateTexture when the quality was changed. It doesn't cost much, because the same function is called when the window size changed.
Details
Details
- Reviewers
elexis - Group Reviewers
Restricted Owners Package (Owns No Changed Paths) Restricted Owners Package (Owns No Changed Paths) - Commits
- rP20011: Change the shadow map quality without restarting the match.
- Trac Tickets
- #4351
- Run the game
- Open any map
- Change the shadow quality
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
A config value per frame sounds like too much work. The config get values call contains a loop.
It seems more clean and performant to call a new engine function from options.json that just deletes the texture and SetupFrame will recreate it automatically.
Comment Actions
Build is green
Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Checking XML files...
http://jw:8080/job/phabricator/1883/ for more details.
Comment Actions
Tried to implement @elexis 's suggestion about notifying. Current state of option.js is pretty much hardcoded.
Comment Actions
Build is green
Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Checking XML files...
http://jw:8080/job/phabricator/1884/ for more details.
Comment Actions
It's a very good patch. Really like seeing the shadow quality changed instantly. Thanks.
| source/renderer/Renderer.cpp | ||
|---|---|---|
| 2138 ↗ | (On Diff #3193) | Ack, is initialized |
| 2139 ↗ | (On Diff #3193) | No newline, no cookies |
| source/renderer/Renderer.h | ||
| 341 ↗ | (On Diff #3193) | Why isn't it grouped with the other getters? |
| source/renderer/scripting/JSInterface_Renderer.cpp | ||
| 64 ↗ | (On Diff #3193) | If we add fake JS code that's one thing, but in C++ the names shouldn't be misleading. So it should be RecreateShadowMap. Otherwise there should be a rock solid schedule when to implement the setter so that it sets something. Luckily JS doesn't complain if we pass more arguments than the function expects. |