Differential D919
Add footprint and obstruction sizes in skirmish farmstead fixing rP20202 Authored by bb on Sep 18 2017, 9:00 PM.
Details Following rP20202 the skirmish farmstead is broken, since it doesn't have a footprint nor obstruction size. These values were removed from the parent template, but not readded to all childs. Now adding the biggest (rome width, pers depth) sizes in this template. Make sure the front stops falling off.
Diff Detail
Event TimelineComment Actions Build is green Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (307 tests)...................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (307 tests)...................................................................................................................................................................................................................................................................................................................OK! Checking XML files... http://jenkins-master:8080/job/phabricator/2053/ for more details. Comment Actions Executing section Default... Executing section Source... Executing section JS... Executing section XML GUI... Executing section Python... Executing section Perl... http://jenkins-master:8080/job/phabricator_lint/537/ for more details. Comment Actions Rome is the widest footprint at 22x18, but Persia is the deepest at 20x20. So we should use a 22x20 footprint (and a 20x18 obstruction). Otherwise looks good. Comment Actions (@bb: You point out an interesting thing, did you yet test what happens when we place a skirmish place holder whose replacer won't fit. Else the natural choice would have been the placeholder visual actor footprint and obstruction) Comment Actions Atlas doesn't care about obstruction, it only makes the building red when overlapping, but you can still place the building (ofc they will visually overlap now). This happens the same with the skirmish replace, you can place it everywhere, also on top of eachother and then the buildings will ingame just be visible as overlapping. To me setting the values for the visualActor seem a bit random (as the visualActor is just random), I rather want the map maker to know that a building of that type will be overlapping when placing it so we avoid collisions as much as possible. Comment Actions Executing section Default... Executing section Source... Executing section JS... Executing section XML GUI... Executing section Python... Executing section Perl... http://jenkins-master:8080/job/phabricator_lint/542/ for more details. Comment Actions Build is green Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (307 tests)...................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (307 tests)...................................................................................................................................................................................................................................................................................................................OK! Checking XML files... http://jenkins-master:8080/job/phabricator/2062/ for more details. Comment Actions Executing section Default... Executing section Source... Executing section JS... Executing section XML GUI... Executing section Python... Executing section Perl... http://jenkins-master:8080/job/phabricator_lint/543/ for more details. Comment Actions That policy seems fine. (Perhaps you opened a Pandora's box, so it would be nice to close that ;-)) Comment Actions Certainly a pandora box, parts of it can/will be done in those temple' patches, others might get an own patch. Thx for the yelling and review! Comment Actions Build is green Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (307 tests)...................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (307 tests)...................................................................................................................................................................................................................................................................................................................OK! Checking XML files... http://jenkins-master:8080/job/phabricator/2063/ for more details. |