This patch deletes the unused binaries/data/mods/public/art/textures/skins/skins/ and ../structural/ images reported by perl checkrefs.pl --check-unused to reduce the size of the public folder. Checked afterwards with perl checkrefs.pl --validate-templates.
Details
- Reviewers
- None
- Group Reviewers
Restricted Owners Package (Owns No Changed Paths)
Agree that deleting these unused textures is indeed an improvement.
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Branch
- /ps/trunk
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 10912 Build 19150: Vulcan Build Jenkins Build 19149: Vulcan Build (macOS) Jenkins Build 19148: Vulcan Build (Windows) Jenkins Build 19147: arc lint + arc unit
Event Timeline
Successful build - Chance fights ever on the side of the prudent.
Linter detected issues:
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1624/display/redirect
Maybe those textures should be moved to the old public folder in https://trac.wildfiregames.com/browser/art_source/trunk/old_public
Maybe that folder should be deleted and moved to 0 A.D. mods, I don't know :/
Well, I don't know either, so I'll leave it up to you to figure out what should be done with deprecated art.
I guess committing this means adding a PR to delenda est :D
If you make a https://github.com/0ADMods/deprecated_art mod I could these files to there, and Delenda Est could then be fixed by simply adding a dependency.