Page MenuHomeWildfire Games

[art] delete some unused textures
Needs ReviewPublic

Authored by Nescio on Jan 21 2020, 1:46 PM.

Details

Reviewers
None
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Summary

This patch deletes the unused binaries/data/mods/public/art/textures/skins/skins/ and ../structural/ images reported by perl checkrefs.pl --check-unused to reduce the size of the public folder. Checked afterwards with perl checkrefs.pl --validate-templates.

Test Plan

Agree that deleting these unused textures is indeed an improvement.

Event Timeline

Nescio created this revision.Jan 21 2020, 1:46 PM
Owners added a subscriber: Restricted Owners Package.Jan 21 2020, 1:46 PM

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1624/display/redirect

Stan added a comment.Jan 21 2020, 1:58 PM

Maybe those textures should be moved to the old public folder in https://trac.wildfiregames.com/browser/art_source/trunk/old_public

Maybe that folder should be deleted and moved to 0 A.D. mods, I don't know :/

Well, I don't know either, so I'll leave it up to you to figure out what should be done with deprecated art.

Stan added a comment.Jan 21 2020, 2:17 PM

I guess committing this means adding a PR to delenda est :D

I guess committing this means adding a PR to delenda est :D

If you make a https://github.com/0ADMods/deprecated_art mod I could these files to there, and Delenda Est could then be fixed by simply adding a dependency.

Stan added a comment.EditedJan 21 2020, 2:39 PM

That sounds nice. He'll probably dump the mod in his though.

Nescio retitled this revision from delete some unused textures to [art] delete some unused textures.Jan 6 2021, 3:48 PM