Subj.
Details
Details
- Reviewers
phosit - Group Reviewers
Restricted Owners Package (Owns No Changed Paths) - Commits
- rP27833: Queries water manager only if a model should account it.
- Apply the patch and compile the game
- Make sure floating and non-floating models behave like without the patch
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Lint Skipped Severity Location Code Message Error source/graphics/Model.cpp:1 LICENCE YEAR1 Inaccurate Copyright Year - Unit
Unit Tests Skipped - Build Status
Buildable 22298 Build 54519: Vulcan Build Jenkins Build 54518: Vulcan Build (macOS) Jenkins Build 54517: Vulcan Build (Windows) Jenkins
Event Timeline
Comment Actions
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/macos-differential/7257/display/redirect
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/8346/display/redirect
Comment Actions
When testing with my mod: when the water rizes the ships get destroied. That shouldn't be the case but it's the same behavior as before the diff.
When testing with extinct vulcano: there are a lot of errors. Again the same behavior as before the diff.