As elexis figured out, setting duplicateplayernames to true breaks lobbied games, cause every client gets renamed to "${nickname} (2)". That is annyoing, looks strange and finally breaks rejoining.
As duplicateplayernames doesn't make any sense with lobby authentication nevertheless, because there won't be any duplicate names, it just gets disabled if lobby authentication is enabled.
Details
Details
Agree with the reasoning. Agree with the code.
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/differential/970/
Comment Actions
I guess so.
Perhaps add a comment that this actually doesn't work with lobby authentication (otherwise the reader might assume it's either policy or just skipping redundant work).
Maybe eh:
// If lobby authentication is enabled, the clients playername has already been registered