Add the
Description
Description
Details
Details
- Auditors
elexis - Committed
wraitii Jul 31 2012, 5:59 PM - Parents
- rP12247: Slight updates to the Corsica map. Also trying my hands at this whole "commit"…
- Branches
- Unknown
- Tags
Event Timeline
/ps/trunk/binaries/data/mods/public/maps/random/pyrenean_sierra.js | ||
---|---|---|
820 | I was already running out of duplication to remove after 4 weeks of removing the duplication in Corsica, Unknown, Snowflake Searocks and every map that places a civic center. |
/ps/trunk/binaries/data/mods/public/maps/random/pyrenean_sierra.js | ||
---|---|---|
9 | should have been !== undefined (or a default argument in the function header rather), because roughness 0 is replaced with 5. | |
167 | Why is that painter definition in the map file and not near the other painter? The effect of that +1 randomness is completely unnoticeable. | |
636 | Is it a trick question? Aquarius? | |
881 | Having this copy of the function helps with not losing it accidentally. |
/ps/trunk/binaries/data/mods/public/maps/random/pyrenean_sierra.js | ||
---|---|---|
533 | "hacky reasons" being the SmoothElevationPainter not producing the desired result. |
/ps/trunk/binaries/data/mods/public/maps/random/pyrenean_sierra.js | ||
---|---|---|
868 | targetHeight is the only difference in the code of the two copies of the function. On Corsica & Sardinia, the passage just goes from start to end, |
/ps/trunk/binaries/data/mods/public/maps/random/pyrenean_sierra.js | ||
---|---|---|
283 | always -PI/12 |
Comment Actions
The duplication crippling was all unified and the file was cleaned top to bottom. Now the code is as beautiful as the map. Thanks for the map!
/ps/trunk/binaries/data/mods/public/maps/random/pyrenean_sierra.js | ||
---|---|---|
881 | Code redundancy in case of failing hardware :p |
/ps/trunk/binaries/data/mods/public/maps/random/pyrenean_sierra.js | ||
---|---|---|
524 | Smoke & mirrors to make the smoothing strength depend on the height. |