HomeWildfire Games

Add the
AuditedrP12248

Description

Add the

Details

Auditors
elexis
Committed
wraitiiJul 31 2012, 5:59 PM
Parents
rP12247: Slight updates to the Corsica map. Also trying my hands at this whole "commit"…
Branches
Unknown
Tags
Unknown

Event Timeline

elexis raised a concern with this commit.Oct 10 2017, 12:47 AM
elexis added a subscriber: elexis.
elexis added inline comments.
/ps/trunk/binaries/data/mods/public/maps/random/pyrenean_sierra.js
820

I was already running out of duplication to remove after 4 weeks of removing the duplication in Corsica, Unknown, Snowflake Searocks and every map that places a civic center.

This commit now has outstanding concerns.Oct 10 2017, 12:47 AM
elexis added inline comments.Oct 16 2017, 8:42 PM
/ps/trunk/binaries/data/mods/public/maps/random/pyrenean_sierra.js
9

should have been !== undefined (or a default argument in the function header rather), because roughness 0 is replaced with 5.

167

Why is that painter definition in the map file and not near the other painter?
Why does it copy 160 lines instead of adding one more argument to the painter and modify two lines of the paint function?

The effect of that +1 randomness is completely unnoticeable.

636

Is it a trick question? Aquarius?

881

Having this copy of the function helps with not losing it accidentally.

elexis added inline comments.Oct 20 2017, 7:12 AM
/ps/trunk/binaries/data/mods/public/maps/random/pyrenean_sierra.js
533

"hacky reasons" being the SmoothElevationPainter not producing the desired result.
A small blend radius leaves a steep impassable shoreline.
A large blend radius leaves too much sand.

elexis added inline comments.Oct 21 2017, 3:56 AM
/ps/trunk/binaries/data/mods/public/maps/random/pyrenean_sierra.js
868

targetHeight is the only difference in the code of the two copies of the function.

On Corsica & Sardinia, the passage just goes from start to end,
on Pyrenean Sierra it creates a passage from start to the center, then a passage from the center to the end,
which is why centerElevation is passed in this variant of the function but not in the other.

elexis added inline comments.Oct 26 2017, 3:52 PM
/ps/trunk/binaries/data/mods/public/maps/random/pyrenean_sierra.js
9

Fixed in rP20354.

167

Nuked in rP20354.

847

1 if statement-> direction.reverse();

852

2 if-statements -> Math.sign(x || 1);

elexis added inline comments.Dec 27 2017, 11:40 PM
/ps/trunk/binaries/data/mods/public/maps/random/pyrenean_sierra.js
283

always -PI/12

elexis accepted this commit.Jan 22 2018, 6:27 AM

The duplication crippling was all unified and the file was cleaned top to bottom. Now the code is as beautiful as the map. Thanks for the map!

All concerns with this commit have now been addressed.Jan 22 2018, 6:27 AM
wraitii added inline comments.
/ps/trunk/binaries/data/mods/public/maps/random/pyrenean_sierra.js
881

Code redundancy in case of failing hardware :p

elexis raised a concern with this commit.Feb 10 2018, 4:49 PM
elexis added inline comments.
/ps/trunk/binaries/data/mods/public/maps/random/pyrenean_sierra.js
524

Smoke & mirrors to make the smoothing strength depend on the height.

This commit now has outstanding concerns.Feb 10 2018, 4:49 PM
elexis accepted this commit.Feb 11 2018, 4:25 PM
All concerns with this commit have now been addressed.Feb 11 2018, 4:25 PM