HomeWildfire Games

Optimizes GetPercentMapExplored by caching explored vertices per player, patch…
AuditedrP13576

Description

Optimizes GetPercentMapExplored by caching explored vertices per player, patch by scroogie, fixes #2012

Details

Auditors
elexis
Committed
benJul 20 2013, 2:50 AM
Parents
rP13575: Pers corral and storehouse updates
Branches
Unknown
Tags
Unknown

Event Timeline

elexis raised a concern with this commit.Jun 12 2017, 5:06 AM
elexis added a subscriber: elexis.
elexis added inline comments.
/ps/trunk/source/simulation2/components/CCmpRangeManager.cpp
563

This LosIsOffWorld check prevents explored tiles outside of the world from being counted in the cache m_ExploredVertices for rejoined clients.

1117

The absence of a LosIsOffWorld check here means that the tiles outside of the world that are (incorrectly) marked as explored here are added to the m_ExploredVertices cache.

Hence rejoined clients have a smaller number of explored tiles than non-rejoined clients returned by GetPercentMapExplored if the initial territory of a player extends outside of the world (what it shouldn't do either), see also #4598.

This commit now has outstanding concerns.Jun 12 2017, 5:06 AM
All concerns with this commit have now been addressed.Jun 16 2017, 9:40 PM