Paths

Table of Contentst

Diffusion 0 A.D. Public Repository rP9951

# Remove SoD inside territories.
AuditedrP9951
Actions

Tags

None

Subscribers

Description

Remove SoD inside territories.

Fix some serialisation issues.

Details

Auditors

Committed

Aug 1 2011, 11:25 PM

Parents

rP9950: Support TerrainChanged messages in scripts, and report use of unsupported…

Branches

Unknown

Tags

Unknown

Event Timeline

philip committed rP9951: # Remove SoD inside territories..Aug 1 2011, 11:25 PM

elexis raised a concern with this commit.Jun 12 2017, 5:12 AM

elexis added a subscriber: elexis.

elexis added inline comments.

/ps/trunk/source/simulation2/components/CCmpRangeManager.cpp
925	For consistency with all the other writes to `m_LosState`, this loop should have received a check for `LosIsOffWorld` too. If it would have introduced here as it ought to, rP13576 wouldn't have introduced a bug by not adding the check either.

This commit now has outstanding concerns.Jun 12 2017, 5:12 AM

elexis mentioned this in D630: Fix PercentMapExplored OOS.Jun 12 2017, 5:19 AM

elexis mentioned this in rP19790: Fix a map exploration OOS on rejoin when starting with territory at the map….Jun 16 2017, 9:39 PM

Fixed by rP19790

elexis accepted this commit.Jun 16 2017, 9:42 PM

All concerns with this commit have now been addressed.Jun 16 2017, 9:42 PM

Changes (3)

Path

Size

ps/

trunk/

source/

simulation2/

components/

CCmpRangeManager.cpp

CCmpTerritoryManager.cpp

rP9951

ps/trunk/source/simulation2/MessageTypes.h

Loading...

ps/trunk/source/simulation2/components/CCmpRangeManager.cpp

Loading...

ps/trunk/source/simulation2/components/CCmpTerritoryManager.cpp

Loading...