HomeWildfire Games

Increasing the generation speed of the maps: Unknown Land
AuditedrP14162

Description

Increasing the generation speed of the maps: Unknown Land

Details

Auditors
elexis
Committed
SpahbodNov 13 2013, 3:30 PM
Parents
rP14161: New Random Map: Mainland. A simple map without any body of water. Also the…
Branches
Unknown
Tags
Unknown

Event Timeline

elexis raised a concern with this commit.Sep 30 2017, 1:25 PM
elexis added a subscriber: elexis.

Applies a performance fix only to unknown_land.js, but not to unknown.js.
The "continent" maptype on unknown.js is still broken, because the loop consumes beyond 3 minutes on my machine, whereas other maps need something like 10-30seconds for the entire loading sceen.
unknown_nomad.js neverintroduce any jagged shoreline for continent since its introduction in rP12747.

/ps/trunk/binaries/data/mods/public/maps/random/unknown_land.js
202

Fixes a bug in the feature by removing the feature. We can achieve a jagged shoreline as well by applying the same ClumpPlacer to ChainPlacer replacement as in other places of this commit with slightly changed numbers.

This commit now has outstanding concerns.Sep 30 2017, 1:25 PM



/ps/trunk/binaries/data/mods/public/maps/random/unknown_land.js
177

It seems that the primary problem with the shoreline algorithm which consumed 1-3min in each copy thereof (and still does in the map that wasn't updated) is due to the first argument of the placer (radius) combined with the constraint that becomes less probable to satisfy the with increasing sizes.

Changing the nr. from 150 to 100 doesn't change the appearance drastically while drastically reducing the time from 1m to 20s.
Reducing from 150 to 50 reduces the time to 9s.
See screenshots.

Dunedan rescinded a token.
Dunedan awarded a token.
Dunedan rescinded a token.
Dunedan awarded a token.
All concerns with this commit have now been addressed.Nov 7 2017, 6:13 PM