Diffusion 0 A.D. Public Repository rP14732

Send messages in queue before closing connection, patch by boeseRaupe. Fixes…
AuditedrP14732
Actions

Tags

None

Subscribers

Description

Send messages in queue before closing connection, patch by boeseRaupe. Fixes #2420

Details

Auditors

Committed

Feb 5 2014, 3:44 AM

Parents

rP14731: Disables checks in os_cpu_LargePageSize Windows implementation, since they…

Branches

Unknown

Tags

Unknown

Event Timeline

JoshuaJB committed rP14732: Send messages in queue before closing connection, patch by boeseRaupe. Fixes….Feb 5 2014, 3:44 AM

elexis mentioned this in rP15106: Fixes a couple dialog buttons.Jun 4 2018, 12:49 PM

elexis raised a concern with this commit.Jun 4 2018, 1:13 PM

elexis added a subscriber: elexis.

elexis added inline comments.

/ps/trunk/source/network/NetTurnManager.cpp
424	This is an ingame message and the NetServer FSM only expects it ingame. But the TurnManager is initialized at the beginning of the loading screen and in the rejoin/synchronization stage as well. So AltF4ing at that time of the game triggers this FSM error: #4594, D1557. This is also lacking the comment that this was intended for resigning and insta-quit. But that doesn't even work and never worked, see #2420#comment:6 I'm not sure anymore if we should add a comment that it only works 10% of the time or delete the line...

This commit now has outstanding concerns.Jun 4 2018, 1:13 PM

elexis mentioned this in D1557: Fix NetServer FSM error when ending the MP match in the loading screen.Jun 4 2018, 1:32 PM

elexis mentioned this in rP21837: Fix network FSM errors when a client closes the game during the loading screen….Jun 5 2018, 4:52 PM

elexis mentioned this in D1565: Always try to flush netmessages when closing the NetClient.Jun 5 2018, 4:59 PM

elexis accepted this commit.Jun 9 2018, 5:14 PM

elexis added inline comments.

/ps/trunk/source/network/NetClient.cpp
151	No reason not to flush the other messages as well afaics: D1565.

All concerns with this commit have now been addressed.Jun 9 2018, 5:14 PM

elexis mentioned this in rP23076: Implement session event subscription system and rewrite TopPanel….Oct 17 2019, 5:10 PM

Changes (4)

Path

Size

ps/

trunk/

source/

network/

NetTurnManager.cpp

NetTurnManager.h

ps/

GameSetup/

rP14732

ps/trunk/source/network/NetClient.cpp

Loading...

ps/trunk/source/network/NetTurnManager.cpp

Loading...

ps/trunk/source/network/NetTurnManager.h

Loading...

ps/trunk/source/ps/GameSetup/GameSetup.cpp

Loading...