HomeWildfire Games

Internationalized the messages of the tutorial AI

Description

Internationalized the messages of the tutorial AI

Details

Committed
GallaecioApr 25 2014, 5:41 AM
Parents
rP14990: Made the developer overlay wide enough for the Long Strings locale
Branches
Unknown
Tags
Unknown

Event Timeline

elexis added a subscriber: elexis.Nov 2 2019, 2:59 PM

AIChat -> translated chat, because the simulation command / GUI notification can be (and later has become) used by any player (for example for the attack request button and the developer overlay opening chat notification).

/ps/trunk/binaries/data/mods/public/gui/session/messages.js
278

The "aichat" message is not a network message, so this case cannot occur / dead code.

elexis added inline comments.Nov 3 2019, 1:41 PM
/ps/trunk/binaries/data/mods/public/simulation/ai/common-api/baseAI.js
92

Appears like this commit made the "chat" simulation command unused (and obsolete because there is no use case for a simulation sent network message that is not translated, unless it was considered an appropriate format for player chatlogs.
But we don't, because the simulation messages are not processed until the next turn, so chatting during pausing wouldn't be possible with that format. (The AI in fact has the same problem that it can't pause during simulation pause, but I guess chatting with AI during pause isn't a wanted feature.)

As it stands, the feature also allows players to send simulation chat messages (with those ending up in the replay but not the regular chat messages), which is probably not designed feature but a side effect.
The AI could send notifications to the GUIInterface through the engine instead of making it a simulation command available to all players.

Then both "chat" and "aichat" simulation commands can be removed.