More tooltip updates. Made the main menu buttons and the in-game resource…
rP1554
Actions

Description

More tooltip updates. Made the main menu buttons and the in-game resource counters use them.
Fixed space/tab inconsistencies in (though not between) GUI XML files.

Details

Committed

philip

Dec 23 2004, 2:56 PM

Parents

rP1553: Update for the default map for the new structure placeholders

Branches

Unknown

Tags

Unknown

Event Timeline

philip committed rP1554: More tooltip updates. Made the main menu buttons and the in-game resource….Dec 23 2004, 2:56 PM

elexis raised a concern with this commit.Aug 27 2019, 1:17 AM

elexis added a subscriber: elexis.

elexis added inline comments.

/ps/trunk/source/gui/GUITooltip.cpp
109	This removes the `_mousepos`, which means that the `SGUIMessage(GUIM_SETTINGS_UPDATED` call from rP1540 is now useless. It was only needed because the caption needs to be rebuilt after _mousepos was changed. but now mousepos is changed before SetSetting on "caption". So the line below should be deleted.
153	The `GUIM_SETTINGS_UPDATED` message is sent by `SetSetting` already, so this second broadcast is only performance waste and misleading to readers. It's here because it was copied from the Show function above from rP1540. But for the Show function it made sense because `CTooltip::SetupText()` depends on `_mousepos`, this one doesn't have a sense I discovered, just copypasta.