HomeWildfire Games

change player color in gamesetup in random and skirmish maps, patch by elexis…

Description

change player color in gamesetup in random and skirmish maps, patch by elexis and stanislas69, fixes #1580

Details

Committed
mimoSep 18 2015, 11:54 PM
Parents
rP17039: Update templates with the previous commit
Branches
Unknown
Tags
Unknown

Event Timeline

elexis added a subscriber: elexis.Jan 10 2020, 9:22 PM

This commit introduces a logical issue:

  • Atlas has UI controls that allow the skirmish map author to specify a Color per player.
  • The gamesetup ignores this color despite the map specifying that and Atlas providing an UI to specify that value.

The issue can be fixed by consuming the values from the Skirmish map and either forcing them to be that value per playerslot or by replacing the selectable Color palette with the one from the map plus the most distant colors from the player_defaults.json.
The latter has been performed in D2483 to resolve the contradiction.

Whether a Skirmish map specifying player colors should still provide the freedom to allow the gamesetup controllers to change that color has evidently never been considered (just like with most other setting types when the Skirmish map type was introduced), exceptt for few open tickets stating that it' seems problematic in one sentence. So that behavior should still be considered possible subject to revision.