Add UpdateAutoScroll calls to some events where they were missing. For example when deleting, cutting, pasting, autocompleting or doubleclicking text. Patch by Vladislav, fixes #4401.
Description
Description
Details
Details
- Committed
elexis Feb 22 2017, 4:28 PM - Parents
- rP19233: Copy the victory and defeat icons, so that they can be replaced easily by…
- Branches
- Unknown
- Tags
- Build Status
Buildable 564 Build 892: Post-Commit Build Jenkins
Event Timeline
Comment Actions
Since trac being dead:
Thanks for the patch!
- Entry for tab not necessary in the engine, as that doesn't change the text, but if the JS page decides to do that it calls engine code which calls the updateautoscroll thing, so it's fine
- Ok with not calling UpdateAutoScroll from DeleteCurSelection as we call it after each occurance and as we'd still likely have to call UpdateAutoScroll afterwards as the text content might be further modified after deletion
- UpdateAutoScroll call after if (hotkey == "cut") not needed in the sense that the cursor is outside of the text field area, but it is still useful to have that call here as the now free space will be filled with the text that was previously invisible before the cursor (test: fill text field completely, cut some text)
- Thanks for linking the chatlog, that has helped with reviewing the patch! Notice the chatlog being from 2016-12-20-QuakeNet-#0ad-dev.log and the patch having addressed some of the comments, in particular the GUIM_LOAD entry