Enable players to open the lobby as a dialog in the gamesetup, running games…
rP20886
Actions

Description

Enable players to open the lobby as a dialog in the gamesetup, running games and the summary screen.

Differential Revision: https://code.wildfiregames.com/D817
Patch By: fpre / ffffffff
Fixes #4106

Details

Auditors

Imarok

Committed

elexis

Jan 16 2018, 4:05 PM

Differential Revision

D817: Lobby Dialog Overlay in-game and gamesetup

Parents

rP20885: fix rP20875

Branches

Unknown

Tags

Unknown

Build Status

Buildable 4501
Build 7861: Post-Commit Build

Event Timeline

elexis committed rP20886: Enable players to open the lobby as a dialog in the gamesetup, running games….Jan 16 2018, 4:05 PM

Wow nice tx! I go quickly to that icon thing for summary and gamesetup. Maybe i get solution for ingame icon.

ffffffff awarded a token.Jan 16 2018, 5:12 PM

When opened the lobby from gamesetup the distance between the back button and the box above is definitely too small:

This commit now has outstanding concerns.Jan 30 2018, 6:49 PM

u have also seen my other big diffs D1153 D210?

In rP20886#27695, @Imarok wrote:

When opened the lobby from gamesetup the distance between the back button and the box above is definitely too small:

aha why that could be a problem

(Notice he means the golden line, not the white one)

In rP20886#27706, @elexis wrote:

(Notice he means the golden line, not the white one)

oh there must be wrong something no gap ther

In rP20886#27707, @ffffffff wrote:

In rP20886#27706, @elexis wrote:

(Notice he means the golden line, not the white one)

oh there must be wrong something no gap ther

wanna fix it?

elexis added inline comments.Nov 19 2019, 2:42 PM

/ps/trunk/binaries/data/mods/public/gui/lobby/lobby.js
403	Defect: When opening the lobby from a running match, the music switches to the menu music, but doesnt switch back to the ingame music when closing the dialog again and resuming the match. Seems easier and posibly more expected to not change the music when opening as a dialog. The statement must have been added here to resume the menu music when ending a lobby game. Which means the same bug is present in the replay menu. If one opens the replay menu, runs a match, then enters the menu screen, there is no music being played. One could also add to `endGame()` in `session.js` but then one doesn't have the loser / winner track in the summary screen in case the current player won / lost. Lobby fix included at D2412.