Diffusion 0 A.D. Public Repository rP22280

Make the ai aware ranges no longer have the barracks class
AuditedrP22280
Actions

Description

Make the ai aware ranges no longer have the barracks class
fixes rP22190

Patch By: Angen
Comments By: Nescio, Stan
Differential Revision: https://code.wildfiregames.com/D1857

Details

Auditors

Committed

bb	May 13 2019, 8:53 PM

Differential Revision

D1857: Correct detected number of Barracks by Petra when building training facilities

Parents

rP22279: Hierarchical pathfinder: Speed up edge update

Branches

Unknown

Tags

Unknown

Build Status

Buildable 7471
Build 12164: Post-Commit Build	Jenkins

Event Timeline

bb committed rP22280: Make the ai aware ranges no longer have the barracks class.May 13 2019, 8:53 PM

Silier added a subscriber: Silier.May 13 2019, 9:07 PM

Silier added inline comments.

/ps/trunk/binaries/data/mods/public/simulation/ai/petra/baseManager.js
804	@bb class is still Stables

bb added inline comments.May 13 2019, 9:14 PM

/ps/trunk/binaries/data/mods/public/simulation/ai/petra/baseManager.js
804	Sounds like we should change that class to singular

Harbormaster completed building B7471: rP22280: Make the ai aware ranges no longer have the barracks class.May 13 2019, 10:40 PM

line 804 introduces class Stable, but in templates it is used Stables so it is not correct

This commit now has outstanding concerns.May 14 2019, 9:29 AM

Silier mentioned this in D1890: Rename class Stables to Stable following introduction in rP22280.May 14 2019, 9:43 AM

bb mentioned this in rP22328: Rename Stables class to Stable since we use the singular forms..May 31 2019, 10:48 PM

Silier accepted this commit.May 31 2019, 10:51 PM

All concerns with this commit have now been addressed.May 31 2019, 10:51 PM

Changes (2)

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

simulation/

ai/

petra/

baseManager.js

headquarters.js

rP22280

View Options

ps/trunk/binaries/data/mods/public/simulation/ai/petra/baseManager.js