Diffusion 0 A.D. Public Repository rP22411

Fix IsInjured call on miraged entities.
AuditedrP22411
Actions

Description

Fix IsInjured call on miraged entities.

rP22298 introduced an "IsInjured" function, used in the GUIInterface.
Mirages must mock this function and this was missed in the original diff.

Tested By: wowgetoffyourcellphone

Differential Revision: https://code.wildfiregames.com/D2018

Details

Auditors

Silier

Committed

wraitii

Jun 29 2019, 7:17 PM

Differential Revision

D2018: Fix IsInjured call to mirages

Parents

rP22410: [Windows] Automated build.

Branches

Unknown

Tags

Unknown

Build Status

Buildable 8116
Build 13211: Post-Commit Build	Jenkins

Event Timeline

wraitii committed rP22411: Fix IsInjured call on miraged entities..Jun 29 2019, 7:17 PM

Harbormaster completed building B8116: rP22411: Fix IsInjured call on miraged entities..Jun 29 2019, 8:12 PM

Silier raised a concern with this commit.Jun 29 2019, 9:11 PM

Silier added a subscriber: Silier.

Silier added inline comments.

/ps/trunk/binaries/data/mods/public/simulation/components/Mirage.js
27	this.injured, this.IsInjured is function

This commit now has outstanding concerns.Jun 29 2019, 9:11 PM

wraitii added inline comments.Jun 29 2019, 9:32 PM

/ps/trunk/binaries/data/mods/public/simulation/components/Mirage.js
27	Critical testing failure on my end that -_- Always the most innocuous looking changes that end up being dangerous.

wraitii mentioned this in rP22412: Fix IsInjured overwrite in rP22411.Jun 29 2019, 9:43 PM

Fixed in rP22412, sorry 'bout that.

Silier accepted this commit.Jun 29 2019, 9:46 PM

All concerns with this commit have now been addressed.Jun 29 2019, 9:46 PM

Changes (1)

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

simulation/

components/

Mirage.js

rP22411

View Options

ps/trunk/binaries/data/mods/public/simulation/components/Mirage.js