Diffusion 0 A.D. Public Repository rP22587

Pass the GUI page pointer CGUI* to the IGUIObject and derived classes upon…
rP22587
Actions

Tags

None

Subscribers

None

Description

Pass the GUI page pointer CGUI* to the IGUIObject and derived classes upon construction, instead of on stray cases.

Call JS_AddExtraGCRootsTracer and JS_RemoveExtraGCRootsTracer depending on JS::Heap use instead of on CGUI page link setup.
GUIObjects should be able to access the GUI page independent of the scripting (for example to obtain PredefinedColors, refs D2108).

Refs: D2108, rP16214
Comments By: wraitii

Details

Committed

Aug 1 2019, 10:20 PM

Parents

rP22586: Replace {gender} by {phenotype} and support this tag in VisualActor.

Branches

Unknown

Tags

Unknown

Build Status

Buildable 8686
Build 14231: Trigger Windows Autobuild
Build 14230: Post-Commit Build	Jenkins

Event Timeline

elexis committed rP22587: Pass the GUI page pointer CGUI* to the IGUIObject and derived classes upon….Aug 1 2019, 10:20 PM

Harbormaster failed to build B8686: rP22587: Pass the GUI page pointer CGUI* to the IGUIObject and derived classes upon…!Aug 1 2019, 10:23 PM

elexis mentioned this in D2108: Pass CGUI in GUIObject constructor, remove GetPreDefinedColor top page workaround.Aug 1 2019, 11:07 PM

elexis mentioned this in D2139: Add virtual base initialization for rP22587.Aug 1 2019, 11:41 PM

elexis mentioned this in rP22589: Add virtual base initialization missing in rP22587..Aug 2 2019, 1:55 AM

elexis mentioned this in D2166: Unfriend IGUIObject from CGUI.Aug 10 2019, 2:24 PM

elexis mentioned this in rP22641: Unfriend the 20 IGUIObject classes from CGUI..Aug 10 2019, 2:51 PM

elexis mentioned this in rP22663: Delete wrongful proxy CGUIManager::GetPreDefinedColor from rP7214..Aug 13 2019, 8:00 PM

elexis mentioned this in D2205: Use CGUI& instead of CGUI*.Aug 20 2019, 5:10 PM

elexis mentioned this in rP22741: Use CGUI& instead of CGUI* so that the 50+ users stop wondering whether or not….Aug 21 2019, 12:12 PM

Changes (39)

Path

Size

ps/

trunk/

source/

gui/

CGUIScrollBarVertical.cpp

CGUIScrollBarVertical.h

CProgressBar.cpp

CRadioButton.cpp

IGUIScrollBar.cpp

IGUIScrollBar.h

IGUIScrollBarOwner.cpp

IGUIScrollBarOwner.h

rP22587

ps/trunk/source/gui/CButton.cpp

Loading...

ps/trunk/source/gui/CButton.h

Loading...

ps/trunk/source/gui/CChart.cpp

Loading...

ps/trunk/source/gui/CChart.h

Loading...

ps/trunk/source/gui/CCheckBox.cpp

Loading...

ps/trunk/source/gui/CCheckBox.h

Loading...

ps/trunk/source/gui/CDropDown.cpp

Loading...

ps/trunk/source/gui/CDropDown.h

Loading...

ps/trunk/source/gui/CGUI.cpp

Loading...

ps/trunk/source/gui/CGUI.h

Loading...

ps/trunk/source/gui/CGUIScrollBarVertical.cpp

Loading...

ps/trunk/source/gui/CGUIScrollBarVertical.h

Loading...

ps/trunk/source/gui/CImage.cpp

Loading...

ps/trunk/source/gui/CImage.h

Loading...

ps/trunk/source/gui/CInput.cpp

Loading...

ps/trunk/source/gui/CInput.h

Loading...

ps/trunk/source/gui/CList.cpp

Loading...

ps/trunk/source/gui/CList.h

Loading...

ps/trunk/source/gui/COList.cpp

Loading...

ps/trunk/source/gui/COList.h

Loading...

ps/trunk/source/gui/CProgressBar.cpp

Loading...

ps/trunk/source/gui/CProgressBar.h

Loading...

ps/trunk/source/gui/CRadioButton.cpp

Loading...

ps/trunk/source/gui/CRadioButton.h

Loading...

ps/trunk/source/gui/CSlider.cpp

Loading...

ps/trunk/source/gui/CSlider.h

Loading...

ps/trunk/source/gui/CText.cpp

Loading...

ps/trunk/source/gui/CText.h

Loading...

ps/trunk/source/gui/CTooltip.cpp

Loading...

ps/trunk/source/gui/CTooltip.h

Loading...

ps/trunk/source/gui/GUIbase.h

Loading...

ps/trunk/source/gui/IGUIObject.cpp

Loading...

ps/trunk/source/gui/IGUIObject.h

Loading...

ps/trunk/source/gui/IGUIScrollBar.cpp

Loading...

ps/trunk/source/gui/IGUIScrollBar.h

Loading...

ps/trunk/source/gui/IGUIScrollBarOwner.cpp

Loading...

ps/trunk/source/gui/IGUIScrollBarOwner.h

Loading...

ps/trunk/source/gui/MiniMap.cpp

Loading...

ps/trunk/source/gui/MiniMap.h

Loading...