Diffusion 0 A.D. Public Repository rP23692

Fix gcc warning reported by Imarok after rP23690
AuditedrP23692
Actions

Description

Fix gcc warning reported by Imarok after rP23690

Introduced in rP23690.
Gcc gives warning about missing parenthesis so this patch is adding them, not changing result of expression.
Fix proposed by Imarok in P206 after report on irc http://irclogs.wildfiregames.com/2020-05/2020-05-22-QuakeNet-%230ad-dev.log.

Differential Revision: https://code.wildfiregames.com/D2762
Reviewed by: elexis

Details

Auditors

elexis

Committed

Silier

May 23 2020, 2:21 PM

Reviewer

elexis

Differential Revision

D2762: Fix gcc warning reported by Imarok after rP23690

Parents

rP23691: [Windows] Automated build.

Branches

Unknown

Tags

Unknown

Build Status

Buildable 11799
Build 21946: Trigger Windows Autobuild
Build 21945: Post-Commit Build	Jenkins
Build 21944: Post-Commit Build (macOS)	Jenkins

Event Timeline

Silier committed rP23692: Fix gcc warning reported by Imarok after rP23690.May 23 2020, 2:21 PM

Silier added an edge: D2762: Fix gcc warning reported by Imarok after rP23690.

Harbormaster completed building B11799: rP23692: Fix gcc warning reported by Imarok after rP23690.May 23 2020, 2:28 PM

Verified that exactly one parenthesis is added that doesn't change the logic of this line and that it resolves the gcc warning, did not check the logic of 23690.

All concerns with this commit have now been addressed.May 23 2020, 4:17 PM

Changes (1)

Path

Size

ps/

trunk/

source/

third_party/

tinygettext/

src/

plural_forms.cpp

rP23692

View Options

ps/trunk/source/third_party/tinygettext/src/plural_forms.cpp