HomeWildfire Games
Diffusion 0 A.D. Public Repository rP24610

Fix common OOS following rP24563.
rP24610
Actions

Description

Fix common OOS following rP24563.

rP24563 uses a GCHashTable to recognize objects. However, It should have used MovableCellHasher to maintain a stble hashmaps when GC pointers change.

Tested By: Stan

Differential Revision: https://code.wildfiregames.com/D3363

Details

Committed
wraitiiJan 14 2021, 9:08 PM
Differential Revision
D3363: Fix random-looking OOS following rP24563
Parents
rP24609: Do not show message box in lobby for an empty message with no sender.
Branches
Unknown
Tags
Unknown
Build Status
Buildable 15047
Build 32558: Trigger Windows Autobuild
Build 32557: Post-Commit BuildJenkins
Build 32556: Post-Commit Build (macOS)Jenkins

Event Timeline

wraitii committed rP24610: Fix common OOS following rP24563..Jan 14 2021, 9:08 PM
wraitii added an edge: D3363: Fix random-looking OOS following rP24563.
Harbormaster completed building B15047: rP24610: Fix common OOS following rP24563..Jan 14 2021, 9:29 PM
Silier added a subscriber: Silier.EditedJan 14 2021, 10:24 PM

does it fix #5909 ?

wraitii added a comment.Jan 14 2021, 10:51 PM
In rP24610#47522, @Angen wrote:

does it fix #5909 ?

I don't think it does necessarily, since you uploaded that ticket before I merged the diff. But it's difficult to know what happened on your playthrough since I OOS much earlier...

Changes (1)

PathSize
ps/
trunk/
source/
simulation2/
serialization/

rP24610

View Options

ps/trunk/source/simulation2/serialization/BinarySerializer.h

Loading...
Wildfire Games · Phabricator