Diffusion 0 A.D. Public Repository rP25442

Remove all external usage of CmptPrivate. Header cleanup.
rP25442
Actions

Description

Remove all external usage of CmptPrivate. Header cleanup.

This removes usage of CmptPrivate outside of ScriptInterface.
ScriptRequest can now be used to safely recover the scriptInterface from a JSContext instead of going through ScriptInterface, which allows more code cleanup.

Follows rP25366

Differential Revision: https://code.wildfiregames.com/D3963

Details

Committed

wraitii

May 15 2021, 3:54 PM

Differential Revision

D3963: Remove all external usage of CmptPrivate. Cleanup.

Parents

rP25441: Adds view bounds test for an ortho camera and removes commented code after…

Branches

Unknown

Tags

Unknown

Build Status

Buildable 17245
Build 39757: Trigger Windows Autobuild
Build 39756: Post-Commit Build	Jenkins
Build 39755: Post-Commit Build (macOS)	Jenkins

Event Timeline

wraitii committed rP25442: Remove all external usage of CmptPrivate. Header cleanup..May 15 2021, 3:54 PM

wraitii added an edge: D3963: Remove all external usage of CmptPrivate. Cleanup..

Harbormaster completed building B17245: rP25442: Remove all external usage of CmptPrivate. Header cleanup..May 15 2021, 5:20 PM

wraitii mentioned this in rP27697: Remove useless line from rP25442.Jun 14 2023, 9:29 AM

Changes (20)

Path

Size

ps/

trunk/

source/

graphics/

MapGenerator.cpp

gui/

GUIManager.cpp

GUIManager.h

Scripting/

JSInterface_GUIManager.cpp

JSInterface_GUIProxy_impl.h

JSInterface_GUISize.cpp

SettingTypes/

CGUISize.cpp

lobby/

scripting/

JSInterface_Lobby.cpp

ps/

GameSetup/

scripting/

scriptinterface/

tests/

test_FunctionWrapper.h

simulation2/

components/

CCmpAIManager.cpp

tests/

test_scripts.h

scripting/

EngineScriptConversions.cpp

serialization/

StdDeserializer.cpp

system/

ComponentManager.cpp

rP25442

View Options

ps/trunk/source/graphics/MapGenerator.cpp

View Options

ps/trunk/source/gui/GUIManager.cpp

View Options

ps/trunk/source/gui/GUIManager.h

View Options

ps/trunk/source/gui/Scripting/JSInterface_GUIManager.cpp

View Options

ps/trunk/source/gui/Scripting/JSInterface_GUIProxy_impl.h

View Options

ps/trunk/source/gui/Scripting/JSInterface_GUISize.cpp

View Options

ps/trunk/source/gui/SettingTypes/CGUISize.cpp

View Options

ps/trunk/source/lobby/scripting/JSInterface_Lobby.cpp

View Options

ps/trunk/source/ps/GameSetup/HWDetect.cpp

View Options

ps/trunk/source/ps/scripting/JSInterface_Mod.cpp

View Options

ps/trunk/source/scriptinterface/FunctionWrapper.h

View Options

ps/trunk/source/scriptinterface/ScriptInterface.cpp

View Options

ps/trunk/source/scriptinterface/ScriptInterface.h

View Options

ps/trunk/source/scriptinterface/ScriptRequest.h

View Options

ps/trunk/source/scriptinterface/tests/test_FunctionWrapper.h

View Options

ps/trunk/source/simulation2/components/CCmpAIManager.cpp

View Options

ps/trunk/source/simulation2/components/tests/test_scripts.h

View Options

ps/trunk/source/simulation2/scripting/EngineScriptConversions.cpp

View Options

ps/trunk/source/simulation2/serialization/StdDeserializer.cpp

View Options

ps/trunk/source/simulation2/system/ComponentManager.cpp

Remove all external usage of CmptPrivate. Header cleanup.rP25442Actions

Description

Details

Event Timeline

Changes (20)

rP25442

ps/trunk/source/graphics/MapGenerator.cpp

ps/trunk/source/gui/GUIManager.cpp

ps/trunk/source/gui/GUIManager.h

ps/trunk/source/gui/Scripting/JSInterface_GUIManager.cpp

ps/trunk/source/gui/Scripting/JSInterface_GUIProxy_impl.h

ps/trunk/source/gui/Scripting/JSInterface_GUISize.cpp

ps/trunk/source/gui/SettingTypes/CGUISize.cpp

ps/trunk/source/lobby/scripting/JSInterface_Lobby.cpp

ps/trunk/source/ps/GameSetup/HWDetect.cpp

ps/trunk/source/ps/scripting/JSInterface_Mod.cpp

ps/trunk/source/scriptinterface/FunctionWrapper.h

ps/trunk/source/scriptinterface/ScriptInterface.cpp

ps/trunk/source/scriptinterface/ScriptInterface.h

ps/trunk/source/scriptinterface/ScriptRequest.h

ps/trunk/source/scriptinterface/tests/test_FunctionWrapper.h

ps/trunk/source/simulation2/components/CCmpAIManager.cpp

ps/trunk/source/simulation2/components/tests/test_scripts.h

ps/trunk/source/simulation2/scripting/EngineScriptConversions.cpp

ps/trunk/source/simulation2/serialization/StdDeserializer.cpp

ps/trunk/source/simulation2/system/ComponentManager.cpp

Remove all external usage of CmptPrivate. Header cleanup.
rP25442
Actions