Diffusion 0 A.D. Public Repository rP25601

Fix and simplify areFilters functions
AuditedrP25601
Actions

Description

Fix and simplify areFilters functions

Workaround is not needed anymore since rP24433

Details

Auditors

Stan

Committed

Silier

May 30 2021, 11:32 AM

Parents

rP25600: [PetraAI] - Make easy difficulties of AI weaker

Branches

Unknown

Tags

Unknown

Build Status

Buildable 17591
Build 40806: Post-Commit Build	Jenkins
Build 40805: Post-Commit Build (macOS)	Jenkins

Event Timeline

Silier committed rP25601: Fix and simplify areFilters functions.May 30 2021, 11:32 AM

Harbormaster completed building B17591: rP25601: Fix and simplify areFilters functions.May 30 2021, 11:51 AM

Stan raised a concern with this commit.May 31 2021, 10:25 AM

Stan added a subscriber: Stan.

Stan added inline comments.

/ps/trunk/binaries/data/mods/mod/gui/modmod/modmod.js
457	Forgot this one and the one below...

This commit now has outstanding concerns.May 31 2021, 10:25 AM

Silier added inline comments.May 31 2021, 8:06 PM

/ps/trunk/binaries/data/mods/mod/gui/modmod/modmod.js
457	D4041

Silier mentioned this in rP25638: Fix areFilters.Jun 2 2021, 7:45 PM

Stan accepted this commit.Jun 2 2021, 7:56 PM

All concerns with this commit have now been addressed.Jun 2 2021, 7:56 PM

Changes (1)

Path

Size

ps/

trunk/

binaries/

data/

mods/

mod/

gui/

modmod/

modmod.js

rP25601

View Options

ps/trunk/binaries/data/mods/mod/gui/modmod/modmod.js