Paths

Table of Contentst

Diffusion 0 A.D. Public Repository rP27962

Split Receiver from SharedState
rP27962
Actions

Description

Split Receiver from SharedState

The Function is not restricted to std::function anymore. Move only function become possible.

Differential Revision: https://code.wildfiregames.com/D4840

Details

Provenance

phosit

Authored on

Differential Revision

D4840: Split Receiver from SharedState

Parents

rP27961: [i18n] Updated POT and PO files.

Branches

Unknown

Tags

Unknown

Build Status

Buildable 22651
Build 55511: Trigger Windows Autobuild
Build 55510: Post-Commit Build
Build 55509: Post-Commit Build (macOS)	Jenkins

Event Timeline

phosit added an edge: D4840: Split Receiver from SharedState.Nov 30 2023, 10:31 AM

phosit committed rP27962: Split Receiver from SharedState.Nov 30 2023, 10:20 AM

vladislavbelov added a subscriber: vladislavbelov.Dec 2 2023, 11:29 PM

vladislavbelov added inline comments.

/ps/trunk/source/ps/Future.h
46–49	The comment is outdated.
297	What will be constructed here?

phosit marked an inline comment as done.Dec 3 2023, 9:22 AM

phosit added inline comments.

/ps/trunk/source/ps/Future.h
297	An object with the same type as `m_Receiver`. `std::shared_ptr<FutureSharedStateDetail::Receiver<ResultType>>` in this case.

vladislavbelov added inline comments.Dec 8 2023, 11:24 AM

/ps/trunk/source/ps/Future.h
297	Where `temp` and `&temp->receiver` will go to as arguments?

vladislavbelov mentioned this in D5208: Don't execute the task when no Future awaits it anymore.Dec 25 2023, 7:24 PM

phosit marked 2 inline comments as done.May 9 2024, 3:52 PM

phosit added inline comments.

/ps/trunk/source/ps/Future.h
297	I think i answerd this question already somewhere else... They are used to construct the `std::shared_ptr`. The aliasing constructor is used.

Changes (2)

Path

Size

ps/

trunk/

source/

ps/

Future.h

tests/

test_Future.h

rP27962

View Options

ps/trunk/source/ps/Future.h