Differential D107

Linear splash damage for boltshooter
ClosedPublic
Actions

Authored by fatherbushido on Jan 29 2017, 5:18 PM.

Details

Reviewers

elexis

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rP19193: Add a linear splash damage for boltshooters. Reviewed by elexis.

Summary

Test Plan

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

fatherbushido created this revision.Jan 29 2017, 5:18 PM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running debug tests...
Running cxxtest tests (302 tests)..............................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/265/ for more details.

Harbormaster completed remote builds in B390: Diff 381.Jan 29 2017, 6:02 PM

fatherbushido added a reviewer: Restricted Owners Package.Jan 29 2017, 9:09 PM

Well, now where it is on phabricator, we might want to write up a test case and actually test it.
For example by uploading a replay where 30 chariots are against 3 bolt shooters.
The replay can then be played with and without the patch, comparing the effects, evaluating whether its becoming OP or something.

In D107#3698, @elexis wrote:

Well, now where it is on phabricator, we might want to write up a test case and actually test it.
For example by uploading a replay where 30 chariots are against 3 bolt shooters.
The replay can then be played with and without the patch, comparing the effects, evaluating whether its becoming OP or something.

are you serious?

commands_3_bolt_vs_30_chariots.txt776 KBDownload

commands_single_bolt.txt12 KBDownload

This revision is now accepted and ready to land.Jan 30 2017, 10:10 AM

Closed by commit rP19193: Add a linear splash damage for boltshooters. Reviewed by elexis. (authored by fatherbushido). · Explain WhyJan 31 2017, 3:48 PM

This revision was automatically updated to reflect the committed changes.

elexis mentioned this in D767: Fix linear splash damage.Aug 3 2017, 10:26 PM

Revision Contents
Changeset List

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

simulation/

templates/

template_unit_mechanical_siege_ballista.xml

8 lines

Diff 414

View Options

ps/trunk/binaries/data/mods/public/simulation/templates/template_unit_mechanical_siege_ballista.xml

Linear splash damage for boltshooterClosedPublicActions