is this better code? not sure
Details
Details
discuss
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
is this better code?
[0] requires the reader know the returned arguments and order, while nick carries that information.
So it must be better code independent of taste.
Comment Actions
Code is the same, changes trivial enough => no new patch required
binaries/data/mods/public/gui/common/gamedescription.js | ||
---|---|---|
24 ↗ | (On Diff #4578) | missing space after { and before } |
154–157 ↗ | (On Diff #4578) | That's a duplicate call, worth a variable |
binaries/data/mods/public/gui/lobby/lobby.js | ||
915 ↗ | (On Diff #4578) | would prefer playerNickRating |