Page MenuHomeWildfire Games
Differential D1087

splitRatingFromNick(playername) cleanup
ClosedPublic
Actions

Authored by ffffffff on Nov 30 2017, 1:48 PM.

Details

Reviewers
bb
elexis
Commits
rP20675: Use an object in splitRatingFromNick instead of an array and some cleanups
Summary

is this better code? not sure

Test Plan

discuss

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

ffffffff created this revision.Nov 30 2017, 1:48 PM
ffffffff updated this revision to Diff 4453.Nov 30 2017, 1:51 PM

up

elexis added a comment.Nov 30 2017, 3:38 PM

is this better code?

[0] requires the reader know the returned arguments and order, while nick carries that information.
So it must be better code independent of taste.

ffffffff added a comment.Nov 30 2017, 4:03 PM
In D1087#43208, @elexis wrote:

is this better code?

[0] requires the reader know the returned arguments and order, while nick carries that information.
So it must be better code independent of taste.

right

ffffffff updated this revision to Diff 4578.Dec 5 2017, 10:17 PM

sync

elexis resigned from this revision.Dec 12 2017, 8:35 PM
bb accepted this revision.Dec 12 2017, 11:54 PM
bb added a subscriber: bb.

Code is the same, changes trivial enough => no new patch required

binaries/data/mods/public/gui/common/gamedescription.js
24

missing space after { and before }

152–155

That's a duplicate call, worth a variable

binaries/data/mods/public/gui/lobby/lobby.js
919

would prefer playerNickRating

This revision is now accepted and ready to land.Dec 12 2017, 11:54 PM
ffffffff added a comment.Dec 13 2017, 12:50 AM

true

tx for review

:))

ffffffff updated this revision to Diff 4764.Dec 13 2017, 12:54 AM
Closed by commit rP20675: Use an object in splitRatingFromNick instead of an array and some cleanups (authored by bb). · Explain WhyDec 22 2017, 8:20 PM
This revision was automatically updated to reflect the committed changes.
Owners added a subscriber: Restricted Owners Package.Dec 22 2017, 8:20 PM

Revision Contents
Changeset List

PathSize
binaries/
data/
mods/
public/
gui/
common/
8 lines
gamesetup/
4 lines
lobby/
15 lines
session/
2 lines

Diff 4453

View Options

binaries/data/mods/public/gui/common/gamedescription.js

Loading...
View Options

binaries/data/mods/public/gui/gamesetup/gamesetup.js

Loading...
View Options

binaries/data/mods/public/gui/lobby/lobby.js

Loading...
View Options

binaries/data/mods/public/gui/session/messages.js

Loading...
Wildfire Games · Phabricator