Page MenuHomeWildfire Games

Buddy game join info in lobby
Needs ReviewPublic

Authored by ffffffff on Dec 1 2017, 1:41 PM.
This revision needs review, but all reviewers have resigned.

Details

Reviewers
elexis
Summary

Giving user chat info about buddies joining a game or opened up a new game.

In the info, game names are colored according to its state.

Buddy names are colored according to its colored names.

Buddy sender info color figured self.

Test Plan

discuss

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

ffffffff created this revision.Dec 1 2017, 1:41 PM
elexis added a comment.Dec 1 2017, 1:53 PM

A feature description beyond one screenshot helps understanding what code is about.
alive is weird terminology (in the context of the diff too).

Would it be easier to store the previous g_GameList in g_GameListPrevious and then just compare?
Otherwise if we only want to store minimum amount of data, why not store g_BuddyGames[buddy_guid] = [ip1, ip2, ...]; and then each time a new gamelist arrives, report the added and removed items.
Also if (x) if (y) is if (x && y) and let (foo of Objects(bar)) is for (let in bar).

In D1090#43276, @elexis wrote:

A feature description beyond one screenshot helps understanding what code is about.
alive is weird terminology (in the context of the diff too).
Would it be easier to store the previous g_GameList in g_GameListPrevious and then just compare?
Otherwise if we only want to store minimum amount of data, why not store g_BuddyGames[buddy_guid] = [ip1, ip2, ...]; and then each time a new gamelist arrives, report the added and removed items.
Also if (x) if (y) is if (x && y) and let (foo of Objects(bar)) is for (let in bar).

discuss is for me completely open for anything. im just suggesting want to have some feedback in desire.

ffffffff updated this revision to Diff 4532.Dec 4 2017, 6:13 PM
ffffffff edited the summary of this revision. (Show Details)

update

ffffffff updated this revision to Diff 4533.Dec 4 2017, 6:14 PM
ffffffff edited the summary of this revision. (Show Details)
ffffffff updated this revision to Diff 4630.Dec 7 2017, 4:48 PM

maybe a much more decent way of infoing about buddies joining games.

ffffffff edited the summary of this revision. (Show Details)Dec 7 2017, 4:49 PM

Would it be easier to store the previous g_GameList in g_GameListPrevious and then just compare?
Otherwise if we only want to store minimum amount of data, why not store g_BuddyGames[buddy_guid] = [ip1, ip2, ...]; and then each time a new gamelist arrives, report the added and removed items.

i want to make it store buddies per game because they can join into multiple games at same time.

g_GameList in g_GameListPrevious and then just compare

the compare im not sure how this code must look like (as im trying to do the same with my diff code :) to follow changes in playerlist :) )

elexis resigned from this revision.Dec 12 2017, 8:35 PM
ffffffff updated this revision to Diff 4776.Dec 15 2017, 9:46 PM

Implement `g_GameListPrevious and compare it to new game list from `Engine.GetGameList()

ffffffff updated this revision to Diff 4777.Dec 15 2017, 9:56 PM

missing parts

ffffffff edited the summary of this revision. (Show Details)Dec 15 2017, 9:56 PM