Some cleanup split from D1050.
Details
Details
- Reviewers
- None
- Commits
- rP20652: Cleanup getNumPlayers() calls
ResourceSupply was doing one too many.
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
| binaries/data/mods/public/simulation/components/EndGameManager.js | ||
|---|---|---|
| 141 ↗ | (On Diff #4679) | Why this was removed? Wouldn't it be broken in non-visual replays (where we don't have GUI)? |
| binaries/data/mods/public/simulation/components/EndGameManager.js | ||
|---|---|---|
| 141 ↗ | (On Diff #4679) | I was under the impression that system entities always existed, so there was no need to check them. But obviously I could be wrong! Testing a non-visual replay, it seemed to work fine. |
| binaries/data/mods/public/simulation/components/EndGameManager.js | ||
|---|---|---|
| 141 ↗ | (On Diff #4679) | You checked that this code was executed? |
| binaries/data/mods/public/simulation/components/EndGameManager.js | ||
|---|---|---|
| 141 ↗ | (On Diff #4679) | That was on start, so let me check at the end of game too... yep. So it seems even though there's no GUI there still is a GuiInterface component. |
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Updating workspaces... Build (release)... Build (debug)... Running release tests... Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK! Checking XML files...
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Updating workspaces... Build (release)... Build (debug)... Running release tests... Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK! Checking XML files...
Comment Actions
There are two more in triggerHelper and wonderVictory (don't be scared of giving my patches some rebase work ;) ), I suppose the endgamemanager is left out for D1115.
| binaries/data/mods/public/simulation/components/Capturable.js | ||
|---|---|---|
| 299–300 ↗ | (On Diff #4680) | I guess inlining makes stuff slower so ok |
| binaries/data/mods/public/simulation/components/ResourceSupply.js | ||
| 37 ↗ | (On Diff #4680) | meh newline could be removed |
| 38 ↗ | (On Diff #4680) | wtf is that comment?, nonsense I suppose since gaia == 0 |
| binaries/data/mods/public/maps/scripts/TriggerHelper.js | ||
|---|---|---|
| 152 ↗ | (On Diff #4761) | This function is then inlined in a loop when it's called, but it doesn't seem like it's called that often so I'm not going to change anything. |
| binaries/data/mods/public/maps/scripts/WonderVictory.js | ||
| 36–37 ↗ | (On Diff #4761) | There's other cleanup possibilities here but I'll leave it for someone else. |
| binaries/data/mods/public/maps/scripts/WonderVictory.js | ||
|---|---|---|
| 36–37 ↗ | (On Diff #4761) | :) |
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Updating workspaces... Build (release)... Build (debug)... Running release tests... Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK! Checking XML files...