hit cancel to hide (escape)
Details
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
This has the same problem as described in D1244 (hit esc quickly after opening the gamesetup), but it should be fixed by checking for onSelectTab in selectPanel, further patch looks good
binaries/data/mods/public/gui/common/tab_buttons.js | ||
---|---|---|
70–72 ↗ | (On Diff #5525) | imo only the onSelectTab call doesn't have to be executed, but the setting of g_TabCategory and setting some sprites can be executed, when pressing esc before the init, the tabs will be hidden. So the check can move to old L75, this also allows not setting the function, if that is required somewhere |
I misread in last comment, patch actually correct. A hotkey string should be added after the release
binaries/data/mods/public/gui/gamesetup/gamesetup.xml | ||
---|---|---|
10 ↗ | (On Diff #5536) | If there were more collapsible elements, one might consider moving that to the tabs UI and possibly creating a custom hotkey to distinguish closing of the options dialog. |