Differential D1249

Show Offline And Defeated Players In Observer Dropdown In Different Color
Needs ReviewPublic
Actions

Authored by ffffffff on Jan 23 2018, 3:33 PM.

Tags

None

Subscribers

Details

Reviewers

Summary

Idea for showing Offline And Defeated Players In Observer Dropdown In Different Color

https://imgur.com/a/88UIU

update
https://imgur.com/a/zl0Lt

Test Plan

test

Diff Detail

Lint

Lint Skipped

Unit

Unit Tests Skipped

Event Timeline

ffffffff created this revision.Jan 23 2018, 3:33 PM

bb added inline comments.Jan 31 2018, 10:48 PM

binaries/data/mods/public/gui/session/session.js
454–456	colors in global Don't we have colorizePlayername function or so (otherwise use stringtags) colors needs to be well choosen, using grey for offline and red for defeated seems ok, also that defeated goes before offline is good (offline deeated players could be best set as defeated)
455	why double negate? if a single is really required (which is doubtful) use that instead

ffffffff added inline comments.Feb 1 2018, 8:34 AM

binaries/data/mods/public/gui/session/session.js
454–456	oh jea stringtags will come! y
455	i guess the offline attribute is not always set see L342 only set when player is offline so check true with double negate to catch error if not existent

Also showing rejoining color
and defeated offline darker red
https://imgur.com/a/zl0Lt

ffffffff edited the summary of this revision. (Show Details)Feb 7 2018, 11:27 AM

That's nice.
Red is bad though maybe a different shade would work.

Revision Contents
Changeset List

Path

Size

binaries/

data/

mods/

public/

gui/

session/

5 lines

19 lines

Diff 5620

binaries/data/mods/public/gui/session/messages.js

Loading...

binaries/data/mods/public/gui/session/session.js

Loading...