Page MenuHomeWildfire Games
Differential D1570

Fix typo in lobby server README
AbandonedPublic
Actions

Authored by mmoanis on Jun 9 2018, 11:01 PM.

Details

Reviewers
Dunedan
Summary

Found typo while working on D1525

Test Plan

checked the grammar :)

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

mmoanis updated this revision to Diff 6745.Jun 9 2018, 11:01 PM
mmoanis created this revision.
bb added a subscriber: bb.Jun 12 2018, 3:57 PM
bb added inline comments.
source/tools/XpartaMuPP/README.md
92

Maybe I am too much nitpicking, but should there be one or more than one account in order to function?

mmoanis added inline comments.Jun 12 2018, 8:29 PM
source/tools/XpartaMuPP/README.md
92

According to the README, two accounts for each. No idea if 1 can work for both.

Dunedan accepted this revision.Jul 8 2018, 8:17 PM
Dunedan added a subscriber: Dunedan.
Dunedan added inline comments.
source/tools/XpartaMuPP/README.md
92

Each of them needs one account. To me the adjusted text is clear enough.

This revision is now accepted and ready to land.Jul 8 2018, 8:17 PM
elexis abandoned this revision.Oct 28 2018, 2:12 AM
elexis added a subscriber: elexis.

That one letter is indeed wrong, but it seems a bit overkill to make a revision proposal and a commit for only one letter. Another spelling error was found in D27. There are a number of things missing in the readme that can be found by following the steps too. I'm uploading a diff.

Revision Contents
Changeset List

PathSize
source/
tools/
XpartaMuPP/
2 lines

Diff 6745

View Options

source/tools/XpartaMuPP/README.md

Loading...
Wildfire Games · Phabricator