Page MenuHomeWildfire Games

Improve the description of the Teacher aura
ClosedPublic

Authored by Gallaecio on Jun 16 2018, 11:46 AM.

Details

Summary

Reported by GunChleoc on Transifex.

Test Plan

Only affects a user-visible string.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Gallaecio created this revision.Jun 16 2018, 11:46 AM
Stan added a subscriber: Stan.Jun 16 2018, 11:55 AM

Maybe fifty could be replaced by half or something ?

For consistency and readability, I think that is it better the way it is.

Consistency because we use percentages for other, similar amounts, including -20% on the same string. To keep consistency, switching 50% to ‘half’ would require changing 20% to ‘a fifth’.

Readability because numbers are easier to spot than words when scanning a string for amounts. And readability is important in all strings that provide players with information relevant to the game (as opposed to strings that do not affect the game, such as those covering historical background).

Vulcan added a subscriber: Vulcan.Jun 16 2018, 12:21 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/653/display/redirect

bb accepted this revision.Jun 18 2018, 4:15 PM
bb added a subscriber: bb.

Seems to be a pleonasm between research and technologies, but with costs also there => meh => ok

This revision is now accepted and ready to land.Jun 18 2018, 4:15 PM
This revision was automatically updated to reflect the committed changes.