Page MenuHomeWildfire Games

Expose Hierarchical Pathfinder's reachability functions (D53 outtake, D13 prerequisite)
Needs ReviewPublic

Authored by wraitii on Apr 20 2019, 10:22 AM.

Details

Reviewers
None
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Summary

This lets code use the HierarchicalPathfinder's reachability helpers, such as "NavcellIsReachable" and "MakeGoalReachable". D13 uses it to fix the short/long-range pathfinders discrepancies.

(D53 outtake)

Test Plan

Review interface and comments, mostly

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
D53_hierarchical_upgrade
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 7223
Build 11771: Vulcan BuildJenkins
Build 11770: arc lint + arc unit

Event Timeline

Build failure - The Moirai have given mortals hearts that can endure.

Linter detected issues:
Executing section Source...

source/simulation2/components/ICmpPathfinder.h
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2019" year instead of "2017"

source/simulation2/components/CCmpPathfinder_Common.h
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2019" year instead of "2017"

source/simulation2/components/CCmpPathfinder.cpp
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2019" year instead of "2018"

source/simulation2/helpers/LongPathfinder.h
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2019" year instead of "2017"
Executing section JS...
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/differential/1239/display/redirect

Stan added a subscriber: Stan.Apr 22 2019, 4:02 PM
Stan added inline comments.
source/simulation2/helpers/LongPathfinder.h
250

Looks like parenting didn't work...

wraitii added inline comments.Apr 22 2019, 4:02 PM
source/simulation2/helpers/LongPathfinder.h
250

Is it supposed to work?