Page MenuHomeWildfire Games

Adds Camera test for ortho projection
ClosedPublic

Authored by vladislavbelov on Mon, Jun 3, 9:14 PM.

Details

Reviewers
wraitii
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP22340: Adds Camera test for ortho projection.
Summary

Subj.

Test Plan
  1. Apply the patch and compile tests
  2. Run tests test TestCamera
  3. Check that all tests are passed

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vladislavbelov created this revision.Mon, Jun 3, 9:14 PM
Vulcan added a comment.Mon, Jun 3, 9:19 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/1593/display/redirect

Angen added a subscriber: Angen.Tue, Jun 4, 1:07 PM

All tests passed

wraitii added a subscriber: wraitii.Wed, Jun 5, 7:10 PM
wraitii added inline comments.
source/lib/self_test.h
70 ↗(On Diff #8293)

What's the purpose of CXXTEST_TEMPLATE_INSTANTIATION here over template<> ?

vladislavbelov added inline comments.Wed, Jun 5, 8:39 PM
source/lib/self_test.h
70 ↗(On Diff #8293)

Because of documentation for the adding custom ValueTraits, it uses CXXTEST_TEMPLATE_INSTANTIATION. I prefer to use the macro, because the value of the macro can be changed.

wraitii accepted this revision.Wed, Jun 5, 9:25 PM

Alrighty then. Tests pass -> Commit.

This revision is now accepted and ready to land.Wed, Jun 5, 9:25 PM
This revision was automatically updated to reflect the committed changes.