Page MenuHomeWildfire Games

Alternative approach on D1955.
AbandonedPublic

Authored by Freagarach on Fri, Jul 26, 10:22 PM.

Details

Reviewers
wraitii
Summary

This is an alternative approach on D1955. Here the string replacement is done in Identity.js instead of in a CCmp, this making it more generic and easier extendable.

Test Plan

Use the "{phenotype}"-tag in the "VisualActor"-node and all should be fine.

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
/ps/trunk
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 8618
Build 14116: Vulcan BuildJenkins
Build 14115: arc lint + arc unit

Event Timeline

Freagarach created this revision.Fri, Jul 26, 10:22 PM
Owners added a subscriber: Restricted Owners Package.Fri, Jul 26, 10:22 PM

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...

source/simulation2/components/ICmpIdentity.h
|  27| class·ICmpIdentity·:·public·IComponent
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'classICmpIdentity:' is invalid C code. Use --std or --language to configure the language.

source/simulation2/components/ICmpVisual.h
|  35| class·ICmpVisual·:·public·IComponent
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'classICmpVisual:' is invalid C code. Use --std or --language to configure the language.
Executing section JS...

binaries/data/mods/public/simulation/components/Identity.js
| 224| »   return·visualActor;
|    | [NORMAL] ESLintBear (consistent-return):
|    | Function expected no return value.
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/244/display/redirect

I don't find that cleaner to be honest.

Freagarach abandoned this revision.Sun, Jul 28, 7:37 AM

I don't find that cleaner to be honest.

Loud and clear ;)