rP22695 left the Value variable of SetSettingWrap unused.
Details
Details
- Reviewers
- None
- Commits
- rP22720: Erase unused variable following rP22695, clean two stray includes from rP1507.
Notice that this code is subject to revision, so the next caller that wants to use that argument may add it easily, since there are only 2 calls to it.
Strictly speaking, the Coding Conventions don't require includes to be grouped at the head of the file:
The #include instructions, placed after the license notice, should follow a consistent order.
But it still seems more transparent if they are grouped, so that one isn't surprised of a new include in the middle of the implementation or declaration.
Also fixes a typo in rP22689 that Stan pointed out and a confusion of image and sprite in a comment in rP22682.
The two stray includes come from rP1507.
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Linter detected issues:
Executing section Source...
source/gui/CGUISprite.h
| 176|
| | [MAJOR] CPPCheckBear (syntaxError):
| | Code 'classCClientArea{' is invalid C code. Use --std or --language to configure the language.
source/gui/GUIRenderer.h
| 34| namespace·GUIRenderer
| | [MAJOR] CPPCheckBear (syntaxError):
| | Code 'namespaceGUIRenderer{' is invalid C code. Use --std or --language to configure the language.
source/gui/GUIutil.h
| 35| template<typename·T>·class·GUI;
| | [MAJOR] CPPCheckBear (syntaxError):
| | Code 'template<...' is invalid C code. Use --std or --language to configure the language.
Executing section JS...
Executing section cli...Link to build: https://jenkins.wildfiregames.com/job/docker-differential/437/display/redirect