Further fixes for Generalized Attack D2092/rP22754 : don't early-return but continue if an entity does not have a receiver, and polar sea triggers fix
ClosedPublic
Actions

Authored by wraitii on Aug 31 2019, 1:51 PM.

Details

Reviewers: None
Commits: rP22814: Further fixes for Generalized Attack D2092/rP22754

Summary

As reported by Freagarach for D2092/rP22754.

Test Plan

Check that polar sea works correctly, and notice that the new code allows taking capture if the entity does not have health.

Diff Detail

Repository

rP 0 A.D. Public Repository

Branch

master_up

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 9120
Build 14947: Vulcan Build	Jenkins
Build 14946: Vulcan Build (Windows)	Jenkins
Build 14945: arc lint + arc unit

Event Timeline

wraitii created this revision.Aug 31 2019, 1:51 PM

Owners added a subscriber: Restricted Owners Package.Aug 31 2019, 1:51 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/518/display/redirect

elexis retitled this revision from Further fixes for rP22754 : don't early-return but continue if an entity does not have a receiver, and polar sea triggers fix to Further fixes for Generalized Attack D2092/rP22754 : don't early-return but continue if an entity does not have a receiver, and polar sea triggers fix.Aug 31 2019, 2:24 PM

elexis edited the summary of this revision. (Show Details)

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/9/display/redirect

Harbormaster failed remote builds in B9120: Diff 9541!Aug 31 2019, 5:18 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/13/display/redirect

Harbormaster completed remote builds in B9120: Diff 9541.Aug 31 2019, 5:30 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 1 2019, 9:29 AM

Closed by commit rP22814: Further fixes for Generalized Attack D2092/rP22754 (authored by wraitii). · Explain Why

This revision was automatically updated to reflect the committed changes.

wraitii added a commit: rP22814: Further fixes for Generalized Attack D2092/rP22754.