Mark GetAnimationName as const
ClosedPublic
Actions

Authored by elexis on Mar 22 2017, 10:54 PM.

Details

Reviewers

Commits

rP19325: Mark GetAnimationName as const

Summary

D219 / rP19299 introduced the GetAnimationName function, but didn't mark that as const.
(As mentioned in the test plan of D219, I got some crash when originally trying to make it const, but I can't reproduce it anymore, no matter which weird things I try).

Test Plan

Make sure that it compiles. The function can be tested with D204.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

elexis created this revision.Mar 22 2017, 10:54 PM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/575/ for more details.

Harbormaster completed remote builds in B845: Diff 897.Mar 22 2017, 11:39 PM

• leper accepted this revision.Mar 23 2017, 12:05 AM

This revision is now accepted and ready to land.Mar 23 2017, 12:05 AM

Closed by commit rP19325: Mark GetAnimationName as const (authored by elexis). · Explain WhyMar 23 2017, 12:07 AM

This revision was automatically updated to reflect the committed changes.

Thanks for keeping an eye on my broken C++ commits!